Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0.1xx] [XC] compile StaticResource w/ generics #25352

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #25344 to release/9.0.1xx

/cc @PureWeen @StephaneDelcroix

@github-actions github-actions bot requested a review from a team as a code owner October 17, 2024 15:23
@github-actions github-actions bot requested review from mattleibow and rmarinho and removed request for a team October 17, 2024 15:23
@jsuarezruiz jsuarezruiz added the area-xaml XAML, CSS, Triggers, Behaviors label Oct 18, 2024
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@PureWeen
Copy link
Member

/rebase

{StaticResource} are now compiled when possible, there was an issue,
throwing NRE, when the target property of the resource is of generic
type.
It was only possible to depict in the very contrived and overengineerd
design of the converters in Community toolkit.

- fixes #25309
@github-actions github-actions bot force-pushed the backport/pr-25344-to-release/9.0.1xx branch from 85c37b4 to bb42b5f Compare October 18, 2024 12:56
@PureWeen
Copy link
Member

  • failing tests unrelated

@PureWeen PureWeen merged commit 8bd9d88 into release/9.0.1xx Oct 19, 2024
2 of 4 checks passed
@PureWeen PureWeen deleted the backport/pr-25344-to-release/9.0.1xx branch October 19, 2024 18:59
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-xaml XAML, CSS, Triggers, Behaviors fixed-in-9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants