Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Android, respect Minimum/Maximum size requests even when size is set #25164

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

spadapet
Copy link
Contributor

@spadapet spadapet commented Oct 9, 2024

Description of Change

This change is for Android layout only: Clamp the final width/height within the minimum/maximum sizes. Since the layout mode is being set to MeasureSpecMode.Exactly, we need to give Android the exact final measurement, it will not take minimum/maximum size requests into account.

See the bug for full info.

Issues Fixed

Fixes:

@spadapet spadapet requested a review from PureWeen October 9, 2024 23:31
@spadapet spadapet self-assigned this Oct 9, 2024
@spadapet spadapet requested a review from a team as a code owner October 9, 2024 23:31
@spadapet spadapet requested a review from Eilon October 9, 2024 23:31
@jsuarezruiz jsuarezruiz added platform/android 🤖 area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter labels Oct 10, 2024
@PureWeen PureWeen added this to the .NET 9 SR1 milestone Oct 23, 2024
@spadapet spadapet merged commit 76a76fb into main Nov 4, 2024
97 checks passed
@spadapet spadapet deleted the dev/peterspa/AndroidMinMaxSizeRequest branch November 4, 2024 16:36
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter fixed-in-9.0.10 platform/android 🤖
Projects
Status: Done
4 participants