[ios,tests] Fix iOS Header with Group #25157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarinho
changed the title
jsuarezruiz
added
platform/iOS 🍎
area-controls-collectionview
jsuarezruiz
requested changes
Oct 17, 2024
...s/tests/TestCases.Shared.Tests/Tests/CollectionView/CollectionViewUITests.HeaderAndFooter.cs
Show resolved
Hide resolved
rmarinho
force-pushed
the
new-header-tests
branch
from
2445d2b to
861c644
Compare
Fix build Add missing usings
rmarinho
force-pushed
the
new-header-tests
branch
from
861c644 to
fad2ba7
Compare
jsuarezruiz
reviewed
Oct 22, 2024
| @@ -15,6 +15,7 @@ public Issue22104(TestDevice testDevice) : base(testDevice) | |||
| [Test] | |||
| [Category(UITestCategories.CollectionView)] | |||
| [FailsOnMac] | |||
| [FailsOnIOS] | |||
There was a problem hiding this comment.
Could you include a comment here indicating is failing because a bug? Maybe something like:
[FailsOnIOS("A short description - link to the issue if exists")]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes issue when we are using a group and also an header or footer. Since both are SupplementaryElement and seems there's only 1 type of ElementKind.
Looking at the indexPath seems the be a way to decide if we are asking for a global header of from a group header of particular section.