-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C] fix specificity comparison #24891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDelcroix
force-pushed
the
fix_24849
branch
from
September 24, 2024 09:02
0e8d720
to
ae6a105
Compare
- fixes #24849
StephaneDelcroix
changed the title
fix specificity comparison
[C] fix specificity comparison
Sep 24, 2024
var app = new MockApplication(); | ||
app.Resources.Add(new Style24849()); | ||
var page = new Maui24849(useCompiledXaml); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dye resource is already applied here, and should not, but that's another bug for another time
/backport to release/8.0.1xx-sr9 |
Started backporting to release/8.0.1xx-sr9: https://github.com/dotnet/maui/actions/runs/11017409340 |
PureWeen
approved these changes
Sep 24, 2024
samhouts
added
fixed-in-net9.0-nightly
This may be available in a nightly release!
fixed-in-net8.0-nightly
This may be available in a nightly release!
labels
Oct 1, 2024
samhouts
added
fixed-in-9.0.0-rc.2.24503.2
and removed
fixed-in-net9.0-nightly
This may be available in a nightly release!
fixed-in-net8.0-nightly
This may be available in a nightly release!
labels
Oct 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a dynresource replaces another one with the same specificity, keep the last value