Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C] fix specificity comparison #24891

Merged
merged 3 commits into from
Sep 25, 2024
Merged

[C] fix specificity comparison #24891

merged 3 commits into from
Sep 25, 2024

Conversation

StephaneDelcroix
Copy link
Contributor

@StephaneDelcroix StephaneDelcroix commented Sep 24, 2024

When a dynresource replaces another one with the same specificity, keep the last value

@StephaneDelcroix StephaneDelcroix changed the title test for #24489 fix specificity comparison Sep 24, 2024
@StephaneDelcroix StephaneDelcroix changed the title fix specificity comparison [C] fix specificity comparison Sep 24, 2024
@StephaneDelcroix StephaneDelcroix marked this pull request as ready for review September 24, 2024 15:11
@StephaneDelcroix StephaneDelcroix requested a review from a team as a code owner September 24, 2024 15:11
var app = new MockApplication();
app.Resources.Add(new Style24849());
var page = new Maui24849(useCompiledXaml);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dye resource is already applied here, and should not, but that's another bug for another time

@PureWeen
Copy link
Member

/backport to release/8.0.1xx-sr9

Copy link
Contributor

Started backporting to release/8.0.1xx-sr9: https://github.com/dotnet/maui/actions/runs/11017409340

@PureWeen PureWeen merged commit 7005a68 into main Sep 25, 2024
97 checks passed
@PureWeen PureWeen deleted the fix_24849 branch September 25, 2024 00:23
@samhouts samhouts added fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-net8.0-nightly This may be available in a nightly release! labels Oct 1, 2024
@samhouts samhouts added fixed-in-9.0.0-rc.2.24503.2 and removed fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-net8.0-nightly This may be available in a nightly release! labels Oct 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual State manager change in behavior in 8.0.90 breaks "Normal"
3 participants