AppThemeBinding on ToolbarItems #24886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubaflo
added
platform/android 🤖
area-controls-shell
|
@kubaflo Thank you for taking the time to fix this. Do you by any chance also tested this with iOS? Yeterday, when I wrote the bug report, I was unable to show any toolbar items on |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Sep 25, 2024
PureWeen
requested changes
Sep 25, 2024
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue24878.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
PureWeen
approved these changes
Sep 26, 2024
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
pushed a commit
that referenced
this pull request
Sep 30, 2024
* AppThemeBinding on ToolbarItems * Added a UI test * UI test fix * Added a snapshot * Update Issue24878.cs * Added a windows snapshot
samhouts
added
fixed-in-net8.0-nightly
samhouts
added
fixed-in-9.0.0-rc.2.24503.2
fixed-in-net8.0-nightly
|
Does this fix the same issue with Buttons/ImageButtons? |
samhouts
added
fixed-in-9.0.12
and removed
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #24878
Screen.Recording.2024-09-24.at.02.11.13.mov
Screen.Recording.2024-09-24.at.02.09.40.mov