Add Padding for iOS Buttons in some scenarios #24760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tj-devel709
force-pushed
the
dev/TJ/iOSButtonPadding
branch
from
d6e85b3 to
8b3a028
Compare
tj-devel709
force-pushed
the
dev/TJ/iOSButtonPadding
branch
from
8b3a028 to
2f8ed52
Compare
PureWeen
approved these changes
Sep 19, 2024
|
/backport to release/8.0.1xx-sr9 |
|
Started backporting to release/8.0.1xx-sr9: https://github.com/dotnet/maui/actions/runs/10939334860 |
samhouts
added
the
fixed-in-net8.0-nightly
redducks100
pushed a commit
to redducks100/maui
that referenced
this pull request
Sep 24, 2024
* Add padding for buttons that need it and UITest * lost some spaces in the xaml * android and windows screenshot
samhouts
added
the
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
#24746 contains a full description, but essentially, there are edge cases where the user can set padding that is too small for iOS to lay out the button. Prior to changes in SR9, some of these situations looked okay because values for padding and spacing were not always respected. This PR makes it so if the padding set by the user is too small for the title and image in certain situations (described here), the padding will be increased. If the padding is already sufficient, no change will be made.
Issues Fixed
#24746
#24735