Revert "Shell Tab is still visible after set Tab.IsVisible to false" #24588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts #24161
The order of settings these shouldn't different between the platforms
https://github.com/dotnet/maui/pull/24161/files#diff-93d93df387ae9ef2d40df68713dcb222a07258862d357827287b266c8238a821R20-R28
We're noticing this fails on our net9.0 branch as well. I'm not too sure why this fails on the net9.0 branch but not here. When I tested on the net9.0 branch it looks like the current item never gets transitioned after the second tabs visibility changes. Why this works on main but not here? I'm not sure
https://dev.azure.com/xamarin/public/_build/results?buildId=122923&view=ms.vss-test-web.build-test-results-tab&runId=3107208&resultId=100039&paneView=debug
Reverting this for now so we can fix our net9.0 merge and fixing this to be more consistent between the platforms
For the final version of this PR we should add two tests
One that sets visibility with this order
And one that sets it in this order
And make sure both paths work on all platforms