Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Shell Tab is still visible after set Tab.IsVisible to false" #24588

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Sep 3, 2024

Description

Reverts #24161

The order of settings these shouldn't different between the platforms
https://github.com/dotnet/maui/pull/24161/files#diff-93d93df387ae9ef2d40df68713dcb222a07258862d357827287b266c8238a821R20-R28

We're noticing this fails on our net9.0 branch as well. I'm not too sure why this fails on the net9.0 branch but not here. When I tested on the net9.0 branch it looks like the current item never gets transitioned after the second tabs visibility changes. Why this works on main but not here? I'm not sure

https://dev.azure.com/xamarin/public/_build/results?buildId=122923&view=ms.vss-test-web.build-test-results-tab&runId=3107208&resultId=100039&paneView=debug

Reverting this for now so we can fix our net9.0 merge and fixing this to be more consistent between the platforms

For the final version of this PR we should add two tests

One that sets visibility with this order

		Tab2.IsVisible = true;
		Tab3.IsVisible = true;
		Tab1.IsVisible = false;

And one that sets it in this order

		Tab1.IsVisible = false;
		Tab2.IsVisible = true;
		Tab3.IsVisible = true;

And make sure both paths work on all platforms

@PureWeen PureWeen requested a review from a team as a code owner September 3, 2024 22:03
@samhouts samhouts added the area-controls-shell Shell Navigation, Routes, Tabs, Flyout label Sep 4, 2024
@rmarinho rmarinho merged commit 049bfdf into main Sep 4, 2024
95 of 97 checks passed
@rmarinho rmarinho deleted the revert-24161-fix-894511 branch September 4, 2024 13:23
@samhouts samhouts added the fixed-in-net8.0-nightly This may be available in a nightly release! label Sep 5, 2024
@samhouts samhouts added the fixed-in-net9.0-nightly This may be available in a nightly release! label Oct 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout fixed-in-net8.0-nightly This may be available in a nightly release! fixed-in-net9.0-nightly This may be available in a nightly release!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants