Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changed iOS Button Screenshot #24528

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Add changed iOS Button Screenshot #24528

merged 1 commit into from
Aug 30, 2024

Conversation

tj-devel709
Copy link
Member

Description of Change

After #23052 landed, there was one iOS button screenshot test that seems to less than a pixel shifted. This PR checks in that image!

Issues Fixed

@tj-devel709 tj-devel709 added platform/iOS 🍎 area-testing Unit tests, device tests labels Aug 30, 2024
@tj-devel709 tj-devel709 requested a review from a team as a code owner August 30, 2024 01:51
@tj-devel709 tj-devel709 requested review from Eilon and rmarinho August 30, 2024 01:51
@rmarinho rmarinho merged commit e4ac658 into main Aug 30, 2024
95 of 97 checks passed
@rmarinho rmarinho deleted the dev/TJ/ButtonScreenshot branch August 30, 2024 10:53
@samhouts samhouts added fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-net8.0-nightly This may be available in a nightly release! labels Sep 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing Unit tests, device tests fixed-in-net8.0-nightly This may be available in a nightly release! fixed-in-net9.0-nightly This may be available in a nightly release! platform/iOS 🍎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants