Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[X] do not look for parent DataType on collections #24513

Merged
merged 2 commits into from
Sep 3, 2024
Merged

[X] do not look for parent DataType on collections #24513

merged 2 commits into from
Sep 3, 2024

Conversation

StephaneDelcroix
Copy link
Contributor

@StephaneDelcroix StephaneDelcroix commented Aug 29, 2024 •
edited
Loading

Description of Change

  • re-enable XC0022 and XC0023 as WarningsNotAsErrors
  • do not assume that x:DataType is inherited on Picker items

Issues Fixed

@StephaneDelcroix StephaneDelcroix requested a review from a team as a code owner August 29, 2024 15:42
@StephaneDelcroix
Copy link
Contributor Author

the XamlServiceProvider changes needs to be back ported to net8

@samhouts samhouts added the area-xaml XAML, CSS, Triggers, Behaviors label Aug 29, 2024
@StephaneDelcroix
[X] do not look for parent DataType on collections
6a5983d 
- re-enable XC0022 and XC0023 as WarningsNotAsErrors
- do not consider thar x:DataType is inherited on Picker items

- fixes #23989
@mattleibow mattleibow merged commit 92c3ca3 into net9.0 Sep 3, 2024
121 checks passed
@mattleibow mattleibow deleted the fix_23989 branch September 3, 2024 10:20
@samhouts samhouts added the fixed-in-net9.0-nightly This may be available in a nightly release! label Sep 5, 2024
This was referenced Oct 8, 2024
Closed
Closed
@simonrozsival simonrozsival mentioned this pull request Oct 9, 2024
Merged
StephaneDelcroix added a commit that referenced this pull request Oct 10, 2024
@StephaneDelcroix
[X] inherit DataType based on attribute
d21a916 
Change the heuristic for deciding if we need ot ignore parent DataType,
as DataTrigger.Binding shoud inherit it, and
Picker.ItemDisplayNameBinding should not

this is an alternate fix for #23989, partially replaces #24513, and will
help fixing #25141 together with #24152
@StephaneDelcroix StephaneDelcroix mentioned this pull request Oct 10, 2024
Merged
@samhouts samhouts added fixed-in-9.0.0-rc.2.24503.2 and removed fixed-in-net9.0-nightly This may be available in a nightly release! labels Oct 14, 2024
github-actions bot pushed a commit that referenced this pull request Oct 15, 2024
@StephaneDelcroix
[X] inherit DataType based on attribute
963115f 
Change the heuristic for deciding if we need ot ignore parent DataType,
as DataTrigger.Binding shoud inherit it, and
Picker.ItemDisplayNameBinding should not

this is an alternate fix for #23989, partially replaces #24513, and will
help fixing #25141 together with #24152
PureWeen pushed a commit that referenced this pull request Oct 16, 2024
@StephaneDelcroix
[X] inherit DataType based on attribute (#25173)
028cd0c 
Change the heuristic for deciding if we need ot ignore parent DataType,
as DataTrigger.Binding shoud inherit it, and
Picker.ItemDisplayNameBinding should not

this is an alternate fix for #23989, partially replaces #24513, and will
help fixing #25141 together with #24152
github-actions bot pushed a commit that referenced this pull request Oct 17, 2024
@StephaneDelcroix @PureWeen
[X] inherit DataType based on attribute
0e49d76 
Change the heuristic for deciding if we need ot ignore parent DataType,
as DataTrigger.Binding shoud inherit it, and
Picker.ItemDisplayNameBinding should not

this is an alternate fix for #23989, partially replaces #24513, and will
help fixing #25141 together with #24152
github-actions bot pushed a commit that referenced this pull request Oct 17, 2024
@StephaneDelcroix @PureWeen
[X] inherit DataType based on attribute
649a5ed 
Change the heuristic for deciding if we need ot ignore parent DataType,
as DataTrigger.Binding shoud inherit it, and
Picker.ItemDisplayNameBinding should not

this is an alternate fix for #23989, partially replaces #24513, and will
help fixing #25141 together with #24152
github-actions bot pushed a commit that referenced this pull request Oct 18, 2024
@StephaneDelcroix @PureWeen
[X] inherit DataType based on attribute
f079a6f 
Change the heuristic for deciding if we need ot ignore parent DataType,
as DataTrigger.Binding shoud inherit it, and
Picker.ItemDisplayNameBinding should not

this is an alternate fix for #23989, partially replaces #24513, and will
help fixing #25141 together with #24152
PureWeen pushed a commit that referenced this pull request Oct 18, 2024
@github-actions @StephaneDelcroix
[X] inherit DataType based on attribute (#25296)
568fa89 
Change the heuristic for deciding if we need ot ignore parent DataType,
as DataTrigger.Binding shoud inherit it, and
Picker.ItemDisplayNameBinding should not

this is an alternate fix for #23989, partially replaces #24513, and will
help fixing #25141 together with #24152

Co-authored-by: Stephane Delcroix <stephane@delcroix.org>
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattleibow mattleibow mattleibow approved these changes

@simonrozsival simonrozsival simonrozsival approved these changes

@Eilon Eilon Awaiting requested review from Eilon Eilon is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-xaml XAML, CSS, Triggers, Behaviors fixed-in-9.0.0-rc.2.24503.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StephaneDelcroix @simonrozsival @mattleibow @samhouts