RefreshView IsEnabled enhancements #24290
Conversation
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
kubaflo
added
platform/android 🤖
platform/iOS 🍎
area-controls-refreshview
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
I see some new APIs? So this probably needs to go into net9.0 |
I think it's just overrides so should be fine for net8 |
There was a problem hiding this comment.
From a code perspective, this LGTM.
I do want to give it a real test on a device tomorrow so not going to approve right now.
But, in my mind this is basically approved and if someone can test things that they have been suffering with and confirm it is just that much better we can merge. But, I will play in the morning.
|
|
||
| void ICommandElement.CanExecuteChanged(object sender, EventArgs e) | ||
| { | ||
| if((bool)GetValue(IsRefreshingProperty)) |
There was a problem hiding this comment.
Just a nit for if I find any issues otherwise we can fix later (or ignore) so we don't lose the nice green checkmark on this PR.
| if((bool)GetValue(IsRefreshingProperty)) | |
| if (IsRefreshing) |
samhouts
added
the
fixed-in-net8.0-nightly
samhouts
added
the
fixed-in-net9.0-nightly
samhouts
added
fixed-in-9.0.0-rc.2.24503.2
and removed
fixed-in-net9.0-nightly
Description of Change
This Pr is an extension of [Propagate VisualElement.IsEnabled to children]: #12488
Issues Fixed
Fixes #24228
Fixes #19897