Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter names for nested types in complex type equality #33527

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

roji
Copy link
Member

@roji roji commented Apr 12, 2024

Fixes #33449

Note: in extreme cases this may cause us to run up against maximum character limitations of parameter names (not sure we apply identifier limits there...).

@roji roji force-pushed the ComplexTypeParameters branch from d3f70ae to 1a0eac4 Compare April 13, 2024 06:30
@roji roji requested review from maumar and cincuranet April 13, 2024 12:55
@roji roji merged commit 89e9446 into dotnet:main Apr 16, 2024
7 checks passed
@roji roji deleted the ComplexTypeParameters branch April 16, 2024 15:00
roji added a commit to roji/efcore that referenced this pull request Apr 16, 2024
maumar added a commit that referenced this pull request May 1, 2024
…uality (#33527) (#33548)

* Fix parameter names for nested types in complex type equality (#33527)

Fixes #33449

(cherry picked from commit 89e9446)

* adding missing test code

---------

Co-authored-by: maumar <maumar@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants