-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to SQLitePCLRaw 2.0.4 #22297
Update to SQLitePCLRaw 2.0.4 #22297
Conversation
How confident are we that a non-prerelease version will be out in time for us to adopt it? We can't ship 5.0 final with a pre-release dependency. |
"How confident are we" Very confident. |
Should we just wait for that then? |
I'll decline to give any advice on your process. :-) But for additional background: The main purpose of this 2.0.4-pre is to let @bricelam verify that certain changes in my 2.0.4 work are working as expected. If he gives the thumbs-up on this -pre, I expect to do 2.0.4 final next week. If he finds a problem, I still expect to be able to fix it and do 2.0.4 final next week. I suspect that this PR is simply Brice's most convenient way to do the verification I just mentioned. |
LGTM. Just a few test issues to fix. No product issues found. The new bundle_sqlite3 works like a charm on our macOS and Linux (Ubuntu) agents. We can wait for the final 2.0.4 release. I'll get this PR passing and we can just update it when the package is available. |
Sounds great. Thanks @bricelam |
Hello @bricelam! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
5427d7d
to
bbdde6d
Compare
/cc @ericsink @Pilchie
Resolves #22198