You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The SqlStatementExecutor disposes DbCommands and closes the connection before the DbDataReader can be consumed.
Update pipeline uses a Consume(DbDataReader) pattern that could be provided as an Action<T> allowing the executor to control the life-cycle of the ADO objects
Query
Requires a streaming / lazy reader, calling Dispose and closing connection outside of the executor
Reads need to be performed by an IValueBufferFactory to ensure proper typed / untyped reads occour
In FromSql case, requires access to DbDataReader before IValueBufferFactory can be constructed
Activity
Add RelationalCommandBuilder to DI by adding a factory
Add RelationalCommandBuilder to DI by adding a factory
mikary commentedon Sep 24, 2015
The
SqlStatementExecutor
disposesDbCommand
s and closes the connection before theDbDataReader
can be consumed.Consume(DbDataReader)
pattern that could be provided as anAction<T>
allowing the executor to control the life-cycle of the ADO objectsDispose
and closing connection outside of the executorIValueBufferFactory
to ensure proper typed / untyped reads occourFromSql
case, requires access toDbDataReader
beforeIValueBufferFactory
can be constructedAdd RelationalCommandBuilder to DI by adding a factory
Add RelationalCommandBuilder to DI by adding a factory
Add RelationalCommandBuilder to DI by adding a factory
Fix #3110 - Move logic from ISqlStatementExecutor into IRelationalCom…
Fix #3110 - Move logic from ISqlStatementExecutor into IRelationalCom…
6 remaining items