Dont stress opso service #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update constructor to add a flag to get all entries in one call, and use all those dictionary entries instead of making a query for each new login.
When we are rate limited, retrying more often just extends the time out period. Instead, wait longer, and retry fewer times.
IEvangelist
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to recognize community contributors, our tools often use the OSPO REST service to attempt to match a GitHub login to an MS email or alias. This service isn't designed for broad use, and we would get rate limited by repeated API calls.
The What's New tool caused the most problems. Happily, we have many community members that contribute to our docs. The tool would call the REST service for each PR.
In this PR, those tools that will make multiple REST calls now make a single call to retrieve the entire list of MS employees with registered GitHub aliases. That list is only stored in memory while the app runs. Then, each call to determine if a GitHub alias matches an employee uses that in memory cache.
Other tools (seQuester) still make the call for a single ID. Those tools operate on a single issue, and that packet is smaller.