Update sample code for documentation VB.NET "what's new : language features : Tuples" #3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
svick
approved these changes
Sep 18, 2017
BillWagner
approved these changes
Sep 18, 2017
There was a problem hiding this comment.
Thanks for fixing this @Styxxy We appreciate it. The changes are more clear for readers to understand how tuples are used.
I'll 
once the build finishes. These changes should will show up on the live site on our next publish cycle, within a day or so.
rpetrusha
pushed a commit
that referenced
this pull request
Sep 20, 2017
* fix constructor remarks formatting. (#3141) * fix constructor remarks formatting. * another instance * Update String.xml * Update String.xml * | didn't render to `|` properly (#3162) * Added missing space between two words (#3161) * M10669: Possible typo mistake: 'SC1721' (#3167) @wiwagn, It seems that 'SC1721' is a typo of 'CS1721'. Could you help to review this and reply, please? Many thanks in advance! * Update sample code for documentation VB.NET "what's new : language features : Tuples" (#3166) * what's new Tuples : sample use InvariantCulture * vb tuple example fix new language feature sample * fixed broken link (#3169) * fixed pipes in tables (#3163) * added info about relative paths for output (#3042) * added info about relative paths for output * edits * Update how-to-write-a-simple-parallel-for-loop.md (#3174) Updated Cut to Copy in Copy/Cut and Paste this code into ... * fixed formulas (#3182) * fixed formulas * fixed formula * fixed formula * simplifying version list (#3176) * Minor fixes : inconsistent wording and some ghost characters (#3171) * what's new Tuples : sample use InvariantCulture * vb tuple example fix new language feature sample * minor typos * compiler warning corrected to match previously mentioned number * removed a "ghost" quote * fixed inconsistent "read-only" and "read only" * code formatting (missing space) * Adding C# version history post (#2867) * Create csharp-version-history.md * Added the actual text * Updated TOC with my entry. * first pass edit 1. Add Metadata 1. Change person 1. Formalize from blog post to docs style language. * Update csharp-version-history.md * fix build warnings on links. * respond to feedback * fixed build warnings * fixed version capitalization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
In the code snippers of the documentation for VB.NET about Tuples, I found a small error.
Snippet 3 outputs the original string that is being parsed, rather than the output. It should output the result, as it is also being outputted in snippet 1 (the "original" version, before using the new language features). Another minor thing : the variable name of the "to be parsed string" maybe should match the original version?
Summary
Fixes #3165