Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised C# Visual Studio Code tutorial for .NET Core 2.0 #2793

Merged
merged 1 commit into from
Aug 3, 2017

Conversation

rpetrusha
Copy link
Contributor

@rpetrusha rpetrusha commented Jul 31, 2017

Revised C# Visual Studio Code tutorial for .NET Core 2.0

Summary

  • Moved tutorial from the csharp/getting-started folder to the core/tutorials folder. (Or do we want to create a separate core/getting-started folder?)

  • Updated for .NET Core 2.0 (primarily by noting dotnet restore is optional.

Suggested Reviewers

@mairaw, @BillWagner

@rpetrusha rpetrusha changed the title Revised for .NET Core 2.0 Revised C# Visual Studio Code tutorial for .NET Core 2.0 Aug 1, 2017
@rpetrusha rpetrusha added WIP and removed WIP labels Aug 2, 2017
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpetrusha This looks great. I'd say merge when ready.

I left one possible suggestion, which I think is optional because this is a 'get started' tutorial.

![The dotnet restore command](media/with-visual-studio-code/dotnetrestore.png)
![The dotnet restore command](media/with-visual-studio-code/dotnetrestore.png)

* For **.NET Core 2.0**, this step is optional. The `dotnet restore` command executes automatically when a new project is created.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add that dotnet restore runs as a dependent task on each build, if necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BillWagner, I think I'll leave this as is and just merge now.

@rpetrusha rpetrusha merged commit 3bd8800 into dotnet:master Aug 3, 2017
@rpetrusha rpetrusha deleted the vs-code branch August 3, 2017 18:24
mairaw pushed a commit that referenced this pull request Aug 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants