Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Int32 to Integer for Tuples in VB. #24851

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Change Int32 to Integer for Tuples in VB. #24851

merged 2 commits into from
Oct 16, 2024

Conversation

KlausLoeffelmann
Copy link
Member

@KlausLoeffelmann KlausLoeffelmann commented Jun 24, 2021 •
edited by github-actions bot
Loading

@dotnet-bot dotnet-bot added this to the June 2021 milestone Jun 24, 2021
@BillWagner BillWagner self-assigned this Jul 1, 2021
@BillWagner BillWagner modified the milestones: June 2021, July 2021 Jul 1, 2021
BillWagner
BillWagner reviewed Jul 1, 2021
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start @KlausLoeffelmann

Once we address the build issues, this is ready to merge.

docs/visual-basic/programming-guide/language-features/data-types/tuples.md Outdated Show resolved Hide resolved
docs/visual-basic/programming-guide/language-features/data-types/tuples.md Outdated Show resolved Hide resolved
samples/snippets/visualbasic/programming-guide/language-features/data-types/tuple-returns.vb Outdated Show resolved Hide resolved
@BillWagner BillWagner removed this from the July 2021 milestone Aug 5, 2021
@BillWagner BillWagner marked this pull request as ready for review October 16, 2024 17:47
@BillWagner BillWagner requested review from KathleenDollard and a team as code owners October 16, 2024 17:47
@BillWagner BillWagner enabled auto-merge (squash) October 16, 2024 17:49
@BillWagner BillWagner merged commit d64422c into main Oct 16, 2024
9 checks passed
@BillWagner BillWagner deleted the vb/klaus/tuples branch October 16, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

@BillWagner BillWagner BillWagner approved these changes

@KathleenDollard KathleenDollard Awaiting requested review from KathleenDollard KathleenDollard is a code owner

Assignees

@BillWagner BillWagner

Labels
dotnet-visualbasic/svc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KlausLoeffelmann @BillWagner @gewarren @dotnet-bot