Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

top-level getting started portal page #1252

Merged
merged 2 commits into from
Nov 16, 2016
Merged

Conversation

rpetrusha
Copy link
Contributor

Top-level C# Getting Started topic

Summary

The portal page for C# Getting Started topics

Details

Because the TOC is collapsible, if a user is using the TOC for navigation, it looks as if there is no child content because the parent has yet to be written. So I thought I'd write it. This topic mirrors only written content; I haven't included boilerplate topics marked with a wrench.

Suggested Reviewers

@BillWagner @stevehoag @mairaw @kendrahavens

@saldana
Copy link

saldana commented Nov 16, 2016

❌ Validation status: errors

File Status Preview URL Details
docs/csharp/getting-started/index.md ❌Error Details

docs/csharp/getting-started/index.md

  • Line Unspecified: [Error] Author ronpet cannot be recognized in GitHub.

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


This topic shows you how to create and run a simple Hello World application with Visual Studio code and .NET Core.

- [Building a C# Hello World application with .NET Core in Visual Studio 2017 RC](with-visual-studio-2017.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be the VS 2015 topic?

@@ -2,7 +2,7 @@
title: Getting Started | C# Guide
description: Getting Started with C#
keywords: C#, Getting Started, Acquisition, Install
author: dotnet-bot
author: ronpet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rpetrusha - ms.author is ronpet


- [Getting started with Visual Studio Code](with-visual-studio-code.md)

Visual Studio code is a programming editor for Windows, Linux, and macOS that supports IntelliSense (code completion) and debugging.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code should be capitalized


Visual Studio code is a programming editor for Windows, Linux, and macOS that supports IntelliSense (code completion) and debugging.

This topic shows you how to create and run a simple Hello World application with Visual Studio code and .NET Core.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code

@rpetrusha
Copy link
Contributor Author

@stevehoag I've addressed all of your comments.
I also forgot (???) to include the class library topic, so I've added that.
Finally, I noticed a typo in one of the 2015 topics. I've corrected that and included it in this PR.

@stevehoag
Copy link
Contributor

LGTM. Pending a successful build, :shipit:

@saldana
Copy link

saldana commented Nov 16, 2016

⚠️ Validation status: warnings

File Status Preview URL Details
docs/csharp/getting-started/index.md ⚠️Warning View Details
docs/csharp/getting-started/publishing-with-visual-studio.md ✅Succeeded View Details

docs/csharp/getting-started/index.md

  • Line 29: [Warning] Invalid file link:(~/docs/csharp/getting-started/library-with-visual-studio-2017.md).

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@rpetrusha rpetrusha merged commit 3ea9ca4 into dotnet:master Nov 16, 2016
@rpetrusha rpetrusha deleted the starting branch January 18, 2017 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants