This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
Uptake the latest buildtools package, and new CLI #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The buildtools package uses shared framework 1.1.0 instead of 1.0.0, so switch to a matching CLI package. This is the same CLI version as CoreFX and CoreCLR use.
Now more is expected in TestPath that determines the test root. TFM is not added by testing targets anymore. See CoreFX PR 12634.
Without the entry in defaultValues, no ConfigurationGroup was passed to the msbuild command. This caused bin clashes due to a projects not having ConfigurationGroup passed, but the ProjectReferences did have it set due to dir.props.
|
I couldn't track down what buildtools change started the assumption that |
CROSS Risk ReportGenerated: 1/10/2017 10:30:19 AM High Risk Files
Risk Score Totals Total score for high risk files: 10 Total execution time: 1.59 seconds |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buildtools package uses shared framework 1.1.0 instead of 1.0.0, so switch to a matching CLI package. This is the same CLI version as CoreFX and CoreCLR use.
See #1286
Known issues: there are binclashes, and a test failure. I'm submitting this PR as-is as a starting point for making this work. Hopefully anyone who needs to do this upgrade will see this PR first and avoid wasted effort.fixed