Don't skip ProjectReferences silently in TFM.SDK #9307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps with avoiding issues like dotnet/runtime#69139 in the future.
|
/azp run arcade-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
akoeplinger
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProjectReferences that don't have the
GetTargetFrameworkstarget shouldn't be silently skipped. Instead an error should be thrown if the target doesn't exist. Helps with avoiding issues like dotnet/runtime#69139 in the future. I tested this on top of a dotnet/runtime build and it works as expected with the libraries linker change that I'm making to fix the tests.