-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to O preview 2 API. #625
Conversation
Note that API Level 26 (O) is not built by default. To build it, you'll have to specify extra `make` arguments: make AndroidLatestApiLevel=26 AndroidLatestFrameworkVersion=v7.99.0 AndroidPlatformId=O
There is a build issue with O which manifest with See diagnostics build output: https://gist.github.com/garuma/7ca3fb189c154375fddbe6cd8d919c37 /cc @dellis1972 |
@garuma that should be handled by or the one above it.. |
I'm using latest monodroid build (which do seem to reference a xamarin-android commit that has that in). The value is retrieved from the manifest (where you are supposed to set targetAndroidSdkVersion to 'O') not directly from the target framework selected so you wouldn't see it if you don't do that |
@garuma what is in the AndroidManifest.xml targetsdk attribute? |
@garuma not sure if you are talking about this PR, which replaces a handful of SDK components. Sounds more like you are trying it with the latest master. |
True, I figured it could be tackled in the same pass (since it was maybe not caught on the previous one). I can log something external if needed |
Changes: dotnet/java-interop@ec4f819...6608c59 * dotnet/java-interop@6608c59 [generator] Fix generated code that caused CS0169 warnings. (#625) * dotnet/java-interop@0537eb1 Bump to xamarin/xamarin-android-tools/d16-7@310c5cf0 * dotnet/java-interop@59d86de [generator] Add nullable reference types (NRT) support. (#563) * dotnet/java-interop@64c2719 [build] Support building with JetBrains OpenJDK 11 (#629) * dotnet/java-interop@5a21381 [crc64] Change the hash prefix back to `crc64` (#628) * dotnet/java-interop@933876c [crc64] Fix a subtle bug in CRC64 splice-by-8 implementation (#627) * dotnet/java-interop@05c0d7d [performance] Improve speed of our CRC-64 hasher (#624) * dotnet/java-interop@6100554 [Java.Interop.Tools.Cecil] Change DirectoryAssemblyResolver Warning to Diagnostic Output (#622) * dotnet/java-interop@d736086 [generator] simplify life with 'var' in generated code (#621) Various `.csproj` files updated to deal with changes from dotnet/java-interop@9b88ce79, which added a new `Crc64.Table.cs` file and requires use of C# unsafe code. Bump the expected sizes of `.apk` files, as dotnet/java-interop@9b88ce7 increased the size of `Mono.Android.dll`.
Note that API Level 26 (O) is not built by default. To build it, you'll have to specify extra
make
arguments:(I gave up resolving the uber-complicated MSBuild properties puzzle; changing one does not trigger required others, or triggering unwanted property changes, definitely not worthy of spending more than 3 days and nights.)