Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Add validation warning for sealed classes containing benchmarks #2660

Merged
merged 21 commits into from
Oct 27, 2024
Merged

Fixed: Add validation warning for sealed classes containing benchmarks #2660

merged 21 commits into from
Oct 27, 2024

Conversation

ketanpkolte
Copy link
Contributor

  • Added compilation error handling for non-public classes.
  • Added Test for new compilation error handling
  • Removed assertion for private classes and included it in compilation error handling.

@ketanpkolte @timcassell
Update src/BenchmarkDotNet/Validators/CompilationValidator.cs
6616e96 
Co-authored-by: Tim Cassell <35501420+timcassell@users.noreply.github.com>
ketanpkolte and others added 3 commits October 26, 2024 18:55
@ketanpkolte
Added Tests for internal and protected
10143c2 
Update src/BenchmarkDotNet/Validators/CompilationValidator.cs

Co-authored-by: Tim Cassell <35501420+timcassell@users.noreply.github.com>

Added tests for Protected and Internal + cleanup

corrected syntax in message

added individual messages for validation and Tests

Added validation for sealed, notpublic, generic and IsRunnableGenericType
@ketanpkolte
commit
10926f1
@ketanpkolte
Merge pull request #1 from dotnet/master
8a41f12 
Update Master branch
@ketanpkolte
Copy link
Contributor Author

Can you help regarding the commits.
I tried squashing the commits into a single commit but unable to, and rebase also didn't understood well

@timcassell
Copy link
Collaborator

timcassell commented Oct 26, 2024 •
edited
Loading

Don't worry about squash or rebase. Merging from upstream was good enough.

But you should keep your fork's master branch up to date with upstream, and always create a branch for your work. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

timcassell
timcassell approved these changes Oct 27, 2024
View reviewed changes
Copy link
Collaborator

@timcassell timcassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timcassell timcassell merged commit 346bbab into dotnet:master Oct 27, 2024
8 checks passed
@timcassell timcassell added this to the v0.14.1 milestone Oct 27, 2024
@ketanpkolte ketanpkolte deleted the 2516 branch October 27, 2024 06:04
@timcassell timcassell linked an issue Oct 27, 2024 that may be closed by this pull request
Add validation warning for sealed classes containing benchmarks #2516
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timcassell timcassell timcassell approved these changes

Assignees
No one assigned
Labels
Area:Validators
Projects
None yet
Milestone
v0.14.1
Development

Successfully merging this pull request may close these issues.

Add validation warning for sealed classes containing benchmarks
2 participants
@ketanpkolte @timcassell