Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #2645

Merged
merged 4 commits into from
Feb 1, 2017
Merged

Update CONTRIBUTING.md #2645

merged 4 commits into from
Feb 1, 2017

Conversation

Rick-Anderson
Copy link
Contributor

No description provided.

@Rick-Anderson
Copy link
Contributor Author

@tdykstra please review

@@ -4,7 +4,7 @@ The document covers the process for contributing to the articles and code sample

## How to make a simple correction or suggestion

Articles are stored in the repository as Markdown files. Simple changes to the content of a Markdown file can be made in the browser by tapping the **Edit** link in the upper right corner of the browser window. (In narrow browser windows you might need to expand the **options** bar to see the **Edit** link.) Follow the directions to create a pull request (PR). The ASP.NET documentation team will review the PR and accept it or suggest changes.
Articles are stored in the repository as Markdown files. Simple changes to the content of a Markdown file can be made in the browser by selecting the **Edit** link in the upper right corner of the browser window. (In narrow browser windows you'll need to expand the **options** bar to see the **Edit** link.) Follow the directions to create a pull request (PR). We will review the PR and accept it or suggest changes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another instance of "the ASP.NET documentation team" later in the doc that you can also change to we/us for consistency.

Acrolinx always advises removing future tense where possible (you'll --> you)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you sounds too clumsy - I could change it back to might.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave it then, it's only a general preference that you're free to ignore where you don't think it fits.

@Rick-Anderson
Copy link
Contributor Author

@tdykstra removed Core to make it neutral

@tdykstra
Copy link
Contributor

tdykstra commented Feb 1, 2017

Do you want me to merge this? It'll create merge conflicts with what you're doing in aspnetmigration, maybe better to put these changes with those. Edit: I see you just added to this PR.

@tdykstra
Copy link
Contributor

tdykstra commented Feb 1, 2017

References to the aspnet folder and aspnetcore directory need to be updated.

@Rick-Anderson
Copy link
Contributor Author

References to the aspnet folder and aspnetcore directory need to be updated.

@tdykstra Can we do that later or can you do that? Most references are OK I think.

@tdykstra tdykstra merged commit 3ed2442 into master Feb 1, 2017
@tdykstra tdykstra deleted the Rick-Anderson-patch-1 branch February 1, 2017 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants