Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link #25693

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Fix broken link #25693

merged 3 commits into from
Apr 20, 2022

Conversation

henry-js
Copy link
Contributor

@henry-js henry-js commented Apr 20, 2022

Previously referenced .md file is no longer in this repository

@guardrex
Copy link
Collaborator

Hello @henry-js ... Thanks for pointing this out, but this won't be the right fix. We don't point to markdown files. Let me research it out and see what we can do here. I'll edit the PR with whatever I come up with.

@guardrex guardrex self-assigned this Apr 20, 2022
@guardrex
Copy link
Collaborator

I don't see why you're calling this one out, @henry-js. It's live at ...

https://docs.microsoft.com/dotnet/core/testing/unit-testing-code-coverage

@guardrex guardrex closed this Apr 20, 2022
@guardrex
Copy link
Collaborator

HA ... nevermind ... I see we're in a markdown file. 😄 ..... MOREPLZ! ... I'm not fully awake yet.

@guardrex guardrex reopened this Apr 20, 2022
@guardrex
Copy link
Collaborator

@serpent5 ... Is it ok now? I just saw that we'll need the full URL to that topic.

@serpent5
Copy link
Contributor

@guardrex I'll sort it.

@guardrex
Copy link
Collaborator

guardrex commented Apr 20, 2022

Yeah ... it depends if the contributing page shows up at the site. We have markdown files that don't ... that aren't reachable at docs.microsoft.com ... then we need the full URL. If they are reachable at docs.microsoft.com, then the relative URL is cool.

☕ ... NOW! 😆

@serpent5
Copy link
Contributor

serpent5 commented Apr 20, 2022

Yeah, it caught me out too. I "fixed" it by completely undoing the change... 🤦... Should be OK now.

@serpent5 serpent5 merged commit 9933514 into dotnet:main Apr 20, 2022
@serpent5
Copy link
Contributor

Thanks @henry-js.

@guardrex
Copy link
Collaborator

Yeah ... thanks again, @henry-js! 🚀 We don't normally "FIX" a "FIX" for a community-contributed "FIX" ... but it does happen from time-to-time. 😄 The whole docs system is rather complex. There are at least HUNDREDS ... several hundred, probably ... little rules and NITs and 😈 gotchas 😈 around here. The links are one of them because it depends on where they show up and where they're going.

... add on to that a less-than-ideal amount of ☕☕☕☕ for things to get a little sketchy in the morning! 😆

@henry-js henry-js deleted the patch-1 branch April 25, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants