Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dolt bootstrap refactor #8708

Merged
merged 20 commits into from
Jan 2, 2025
Merged

dolt bootstrap refactor #8708

merged 20 commits into from
Jan 2, 2025

Conversation

macneale4
Copy link
Contributor

This change alters the way we resolve the data-dir and initialized dolt processes. It originated from discovering that the tmp dir replace test at startup was leaving a test file in the current working directory. Long story short - the resolution of data-dir was too late in the process startup when sql-server was starting.

External behavior which will change:

  1. Specifying data_dir in sql-server config file will correctly test the ability to rename files on the same partition, and override the TMPDIR environment variable when necessary, using $DATADIR/tmp when the user specified directory is on the wrong partition
  2. Fail to start the server when the data-dir is specified multiple times. This will result in server startup failure for existing deployments which "work" (we choose the data-dir deterministically now, but not in the expected precedence)

Fixes: #8498

@macneale4 macneale4 requested a review from fulghum January 2, 2025 18:11
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
0eeb791 ok 5937457
version total_tests
0eeb791 5937457
correctness_percentage
100.0

@macneale4
Copy link
Contributor Author

Doltgres change to fix tests: dolthub/doltgresql#1097

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice job untangling the datadir initialization.

go/cmd/dolt/commands/sqlserver/command_line_config.go Outdated Show resolved Hide resolved
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
1ff6428 ok 5937457
version total_tests
1ff6428 5937457
correctness_percentage
100.0

Co-authored-by: Jason Fulghum <jason@dolthub.com>
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
5195111 ok 5937457
version total_tests
5195111 5937457
correctness_percentage
100.0

@macneale4 macneale4 merged commit 1fad4fc into main Jan 2, 2025
21 checks passed
@macneale4 macneale4 deleted the macneale4/dolt-bootstrap-refactor branch January 2, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tmpDir doesn't seem to be configurable
3 participants