Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zachmu/case insensitive #665

Merged
merged 7 commits into from
May 8, 2020
Merged

Zachmu/case insensitive #665

merged 7 commits into from
May 8, 2020

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented May 7, 2020

Updated tests for new case-insensitivity improvements in go-mysql-server. Relies on dolthub/go-mysql-server#102, which is not on master yet.

zachmu added 3 commits May 6, 2020 21:20
…syntax errors.

Signed-off-by: Zach Musgrave <zach@liquidata.co>
…remaining test queries

Signed-off-by: Zach Musgrave <zach@liquidata.co>
Signed-off-by: Zach Musgrave <zach@liquidata.co>
@timsehn
Copy link
Contributor

timsehn commented May 7, 2020

We have a bunch of bats tests in capital-letters.bats. Check that out and add some smoke tests in there? Probably should be called case-sensitivity.bats.

@zachmu
Copy link
Member Author

zachmu commented May 7, 2020

Will do

zachmu added 4 commits May 7, 2020 10:15
Signed-off-by: Zach Musgrave <zach@liquidata.co>
Signed-off-by: Zach Musgrave <zach@liquidata.co>
Signed-off-by: Zach Musgrave <zach@liquidata.co>
Signed-off-by: Zach Musgrave <zach@liquidata.co>
@zachmu zachmu merged commit 13468c1 into master May 8, 2020
@Hydrocharged Hydrocharged deleted the zachmu/case-insensitive branch May 11, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants