Android: Add Wii SYSCONF settings to GUI #9088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SYSCONF very much is saveable. Whether it's in IsSettingSaveable or not hasn't mattered until now since the SYSCONF settings use separate config loader code that doesn't check IsSettingSaveable, but the next commit will require SYSCONF to be marked as saveable.
Now that PR 8975 is merged, we can finally add this without hacks. https://bugs.dolphin-emu.org/issues/11605
Ebola16
reviewed
Sep 16, 2020
Any call to Config::SetCurrent will cause the relevant setting to show up as overridden in the Android GUI, which can be confusing, so let's not do it when the new value is the same as the original.
JosJuice
force-pushed
the
android-sysconf
branch
from
c6c9340 to
7749e8c
Compare
|
It's actually correctly reported as overridden. Dolphin automatically disables the PAL60 setting when you run an NTSC game, since some games crash otherwise. I've amended the last commit so that PAL60 doesn't show up as overridden if you actually had it disabled originally, but it showing up as overridden when it originally was enabled is the logical end result of how Dolphin works. |
Ebola16
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that PR #8975 is merged, we can finally add this without hacks.
https://bugs.dolphin-emu.org/issues/11605