Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse arguments before Qt #8683

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Parse arguments before Qt #8683

merged 1 commit into from
Mar 24, 2020

Conversation

AlexApps99
Copy link
Contributor

This is so commands like dolphin-emu --help don't initialise Qt, which wastes memory and prints logs that shouldn't be printed

Before:

$ dolphin-emu --help
qt5ct: using qt5ct plugin
qt5ct: D-Bus global menu: no
Usage: dolphin-emu [options]... [FILE]...

Options:
  --version             show program's version number and exit
...
  -a AUDIO_EMULATION, --audio_emulation=AUDIO_EMULATION
                        Choose audio emulation from [HLE|LLE]

After:

$ dolphin-emu --help
Usage: dolphin-emu [options]... [FILE]...

Options:
  --version             show program's version number and exit
...
  -a AUDIO_EMULATION, --audio_emulation=AUDIO_EMULATION
                        Choose audio emulation from [HLE|LLE]

@leoetlino leoetlino merged commit b3ad3c3 into dolphin-emu:master Mar 24, 2020
@AlexApps99 AlexApps99 deleted the cmdl branch May 9, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexApps99 @leoetlino