Fix Load Wii System Menu not updating after performing a disc update #8675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a fresh install, the button was completely disabled even after the disc update; otherwise, the text on it was just out of date.
leoetlino
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an annoying case where installing the system menu via "Perform System Update" on a disc would fail to enable the Load Wii System Menu item in the tools menu until Dolphin is restarted. If a system menu was already installed, then the old version would still be displayed, but the button was usable.
I also replace the call the "Perform Online Update" function uses to avoid this with a more general one. Note that
NANDRefreshis connected toUpdateToolsMenu:dolphin/Source/Core/DolphinQt/MenuBar.cpp
Line 265 in 0461170