Core/HotkeyManager: Fix group names in config #8655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techjar
force-pushed
the
fix-hotkey-groups
branch
from
e160563 to
1104098
Compare
lioncash
reviewed
Feb 29, 2020
Techjar
force-pushed
the
fix-hotkey-groups
branch
from
1104098 to
a48bd39
Compare
jordan-woyak
approved these changes
Mar 1, 2020
jordan-woyak
reviewed
Mar 1, 2020
Techjar
force-pushed
the
fix-hotkey-groups
branch
from
a48bd39 to
6d83057
Compare
iwubcode
reviewed
Mar 13, 2020
iwubcode
approved these changes
Mar 13, 2020
leoetlino
reviewed
Mar 15, 2020
For some reason every button group was shoved into the same config group called "Keys" which caused buggy behavior once someone tried to have hotkeys with the same name in different groups. This fixes that, and converts existing configs to the new group names so they don't get reset.
Techjar
force-pushed
the
fix-hotkey-groups
branch
from
6d83057 to
ae0c918
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason every button group was shoved into the same config group called "Keys" which caused buggy behavior once someone tried to have hotkeys with the same name in different groups. This fixes that, and converts existing configs to the new group names so they don't get reset.