Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputCommon: Minor ReshapableInput related cleanups. #8647

Merged
merged 5 commits into from
Mar 15, 2020

Conversation

jordan-woyak
Copy link
Member

@jordan-woyak jordan-woyak commented Feb 24, 2020

Because of poor math, calibration sometimes ends up being drawn outside of the mapping indicator.
Calibration values are now clamped within the square shape to prevent this.

Specify the default value when saving calibration center to prevent saving default values.
The eliminates a bunch of irrelevant entries in the ini file for extensions that aren't even configured...

Drums/Stick/Center = 0.00 0.00
Turntable/Stick/Center = 0.00 0.00
uDraw/Stylus/Center = 0.00 0.00
Drawsome/Stylus/Center = 0.00 0.00

RoundStickGate::GetIdealCalibrationSampleCount can return 1.
This makes swing's reshaping math use an actual circle rather than an n-gon.

Fix "Calibration" routine from always setting center value to {0,0} even on cancellation.

Copy link
Member

@BhaaLseN BhaaLseN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems good, untested.

@leoetlino leoetlino merged commit 4944e4b into dolphin-emu:master Mar 15, 2020
@jordan-woyak jordan-woyak deleted the minor-input-cleanups branch March 15, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants