DolphinQt: Give hotkeys their own "background input" setting. #8609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the naming of this is pretty good. It says exactly what it does and it is very clear. Btw, if this default on or off? |
|
The setting is enabled by default. |
Techjar
reviewed
Feb 10, 2020
jordan-woyak
force-pushed
the
separate-hotkey-background-input
branch
from
b7d8a65 to
903db48
Compare
|
LGTM. Not sure I like the setting in the User Interface pane though, maybe move it to Render Window? |
I don't think "Render Window" makes sense. This setting applies even when games aren't running. |
|
Ah, fair enough I guess. |
|
It seems this only considers the render window when checking for focus, which is very impractical for things like the debugger. |
|
@AdmiralCurtiss The window focus logic was already in place. This PR just exposes a separate "Background Input" setting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting is named "Hotkeys Require Window Focus".
Please give opinions on the naming in the UI+INI and whether the checked state should be enabled or disabled.
Fixes: https://bugs.dolphin-emu.org/issues/8262