Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkeys: Toggle Freelook Hotkey #8597

Merged
merged 1 commit into from
Mar 15, 2020
Merged

Conversation

SirMangler
Copy link
Contributor

Straight to the point. A Hotkey to toggle Freelook.

@SirMangler SirMangler changed the title Added Toggle Freelook Hotkey Hotkeys: Toggle Freelook Hotkey Jan 31, 2020
Copy link
Contributor

@MayImilae MayImilae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this idea is fine? I mean, it's not necessary at all, you can just not touch the freelook combination keys, or keep freelook off in the GUI. And if you happen to want to use the shift+WADS key combination for something else while keeping freelook on, you can reassign the hotkeys. But, eh, the hotkeys area is a dump of options for advanced users anyway, and if you made this I assume you have a use case for it, so, eh.

Source/Core/Core/HotkeyManager.cpp Show resolved Hide resolved
@SirMangler
Copy link
Contributor Author

I guess this idea is fine? I mean, it's not necessary at all, you can just not touch the freelook combination keys, or keep freelook off in the GUI. And if you happen to want to use the shift+WADS key combination for something else while keeping freelook on, you can reassign the hotkeys. But, eh, the hotkeys area is a dump of options for advanced users anyway, and if you made this I assume you have a use case for it, so, eh.

The primary reason I made this in the first place is because a user needed it for a fighting game, but frequently needed to disable it for cutscenes (which need to relocate the camera).

Toggling has a couple of advantages over having to manually re-adjust the camera every time, including: reverting back to your desired angle without having to manually set it again (for example an ideal angle for fighting games), allowing the game to take control over the camera (cutscenes), and possibly more than what immediately comes to mind. As you know, without the keybind you need to pause the game and open the settings window and disable the option, then afterwards do the same to enable the option, anytime the game needs the camera (which can include menus as well as cutscenes), or you want to resume the normal camera view. This gets tedious quickly.

This would also be generally handy for users trying to get decent screenshots but need to switch between regular camera and their desired camera angle for setup. I'm sure you get the idea.

This isn't for everyone, but like you mentioned, that's the nature of a lot of the hotkeys.

@leoetlino leoetlino merged commit a66ee4e into dolphin-emu:master Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants