Readme.md Tweak Command Line section #8583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Readme.md
Outdated
| @@ -141,12 +141,13 @@ see where it's stored) if you don't plan to reinstall Dolphin. | |||
| * -A, --audio_emulation=<str> Low level (LLE) or high level (HLE) audio | |||
|
|
|||
| Available DSP emulation engines are HLE (High Level Emulation) and | |||
| LLE (Low Level Emulation). HLE is fast but often less accurate while LLE is | |||
| LLE (Low Level Emulation). HLE is fast but can be less accurate while LLE is | |||
There was a problem hiding this comment.
I think "often" is still a better word here.
There was a problem hiding this comment.
Is HLE incorrect enough to be "often" less accurate than LLE, though?
Maybe something like
Suggested change
| LLE (Low Level Emulation). HLE is fast but can be less accurate while LLE is | |
| LLE (Low Level Emulation). HLE is fast but is less accurate than LLE, which is |
leoetlino
reviewed
Feb 2, 2020
leoetlino
approved these changes
Feb 16, 2020
|
It'd probably read better with less use of the word "which", "HLE is faster but less accurate whereas LLE is slower but close to perfect. Note that LLE has two submodes (Interpreter and Recompiler) but they cannot be selected from the command line." And then "Available video backends are "D3D" and "D3D12" (they are only available on Windows), "OGL", and "Vulkan"." It reads better with an "and" instead of comma for the D3D modes. |
|
That does read better. @Craftyawesome would you mind making those changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds newer backends to readme + more positive about hle accuracy.
The command list itelf is still outdated, though.