Always display the horizontal scroll bar when log word wrap is off #8565
Conversation
Otherwise, a line that's too wide for the log widget will cause the horizontal scroll bar to appear, which reduces the vertical height, and causes the most recent line to be off screen. Since that line is off screen, the log widget no longer scrolls as new lines appear, unless it's manually scrolled to the very bottom again.
|
This seems like behavior all users of Qt would have to deal with. |
|
It already does autoscroll (as far as I can tell, without any manual intervention on Dolphin's behalf; perhaps Qt changed since that thread was created in 2007). This PR just fixes a case where the autoscroll can break. |
|
yes, but i think manually scrolling to the end after lines are pushed would be a better fix for this issue. worth trying at least? |
|
There is a difference — the current automatic scrolling behavior Qt gives allows following the log, but scrolling up to look at older output at which point it'll auto-scrolling until it's scrolled to the end again. Force-scrolling to the end would break that (and if that is done, I'd want a checkbox to disable it, but that'd mean also disabling the Qt auto-scrolling when it's unchecked which I'm not is even possible). |
Otherwise, a line that's too wide for the log widget will cause the horizontal scroll bar to appear, which reduces the vertical height, and causes the most recent line to be off screen. Since that line is off screen, the log widget no longer scrolls as new lines appear, unless it's manually scrolled to the very bottom again.