Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Use square stick calibration #8503

Merged
merged 2 commits into from
Mar 15, 2020

Conversation

JosJuice
Copy link
Member

@JosJuice JosJuice commented Nov 28, 2019

Fixes https://bugs.dolphin-emu.org/issues/11911 and makes the range of values when using touch controls correct. Also affects the range of values for physical controllers in a way that may or may not be desirable, depending on the controller model. (If there are undesirable effects, they would be that the range of inputs is too small, especially diagonally.) Such is our messy Android input system. Should be an improvement on the whole for physical controllers, though.

Otherwise the preferences can end up in a state that is inconsistent
with WiimoteNew.ini.
Fixes https://bugs.dolphin-emu.org/issues/11911 and makes the range of
values when using touch controls correct. Also affects the range of
values for physical controllers in a way that may or may not be
desirable, depending on the controller model. (If there are
undesirable effects, they would be that the range of inputs is too
small, especially diagonally.) Such is our messy Android input system.
Should be an improvement on the whole for physical controllers, though.
@JosJuice JosJuice force-pushed the android-stick-calibration branch from 430036b to d9c78d5 Compare November 28, 2019 17:50
Copy link
Member

@leoetlino leoetlino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, but the changes look simple enough and sane to me. (And you seem to have become the Android maintainer, or the only active contributor to the Android codebase for that matter, so I'll trust you :P)

@leoetlino leoetlino merged commit f81c065 into dolphin-emu:master Mar 15, 2020
@JosJuice JosJuice deleted the android-stick-calibration branch March 15, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants