Always run as X11 app even under Wayland #8357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping? |
|
So merge this until proper Wayland support is done. This is literally just a single changed line. |
|
@Sunderland93: Why 👎? |
|
It's just an environment variable, you can set it yourself. |
Not when there's an icon in the launcher and the user merely clicks on it. 🤦 I don't get the resistance to a very simple change that improves convenience. What does the actual author of the Wayland back-end have to say about this, @stenzek? Will it land very soon or does it make sense to land this PR in the meantime? |
|
Last time I checked qt defaulted to xcb even when under wayland anyway, but being explicit can't hurt.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dolphin doesn't have a working Wayland renderer (not even with
env SDL_VIDEODRIVER=wayland dolphin-emu). By setting theQT_QPA_PLATFORMvariable to "xcb" we ensure that Dolphin runs just fine in any Wayland-based desktop environment instead of displaying an error message.