Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Add GameID to Game Settings title #8353

Merged
merged 1 commit into from
Sep 7, 2019
Merged

Android: Add GameID to Game Settings title #8353

merged 1 commit into from
Sep 7, 2019
+1 −1

Conversation

Ebola16
Copy link
Member

@Ebola16 Ebola16 commented Sep 7, 2019

This helps users make sure they selected the correct game (and not accidentally clear game settings for the wrong game). This also matches the syntax of other titles within Game Settings.

Screenshot_20190906-234250_Dolphin Emulator

JosJuice
JosJuice approved these changes Sep 7, 2019
View reviewed changes
Copy link
Member

@JosJuice JosJuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was planning to add game ID displaying in PR #8188, but I guess it doesn't hurt to have it in the dialog as well.

@lioncash lioncash merged commit 40fc25b into dolphin-emu:master Sep 7, 2019
@Ebola16 Ebola16 deleted the GID branch September 7, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosJuice JosJuice JosJuice approved these changes

@BhaaLseN BhaaLseN BhaaLseN approved these changes

@lioncash lioncash lioncash approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ebola16 @lioncash @BhaaLseN @JosJuice