ConsoleListenerWin: Properly output console logging in UTF-16 #8341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8 displays properly
|
On the other hand Win10 and debugger support are required to support Unicode I guess broken output on older Windows versions might be preferable than broken output on all Windows versions. |
I see this now, yeah. However, since the function itself exists since Windows XP it's essentially a non-issue IMO. If output is going to be broken - tough luck. |
BhaaLseN
approved these changes
Aug 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fix, Windows builds used
OutputDebugStringAfor Console Logger which doesn't handle UTF-8 correctly (A functions assume a local (ACP) codepage). This change explicitly converts an input UTF-8 string to UTF-16 beforehand and passes it to `OutputDebugStringW' instead.This will impact any logging with UTF-8 in it - the most possible scenario is user paths.
Before:
After:
