SI: Reduce logging. #8339
Merged
SI: Reduce logging. #8339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, this was the point. The logs are useless for end-users and the issue is dealt with in a separate PR. |
|
Should we leave a comment next to it for later? |
|
I don't think that's necessary. |
stenzek
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An earlier SI PR added logging for SI devices that return the incorrect number of bytes for certain commands. It turns out pretty much every SI device in dolphin returns the wrong number of bytes (#8239 mostly fixes this). For the time being, it results in loads of non-actionable log spam for users that should probably be suppressed.