Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dualcore INI changes #8328

Merged
merged 1 commit into from
Nov 16, 2019
Merged

Dualcore INI changes #8328

merged 1 commit into from
Nov 16, 2019

Conversation

Miksel12
Copy link
Contributor

Dualcore changes taken from #8164.
I have re-evaluated all the dualcore changes and only included the most important INI changes based on the wiki, issue tracker and forum.
Dualcore has been enabled for 'Baten Kaitos Eternal Wings and the Lost Ocean' as tests on wiki show that it can safely be enabled.

@JMC47
Copy link
Contributor

JMC47 commented Aug 23, 2019

Something I feel strongly about for down the road is saying why a feature is disabled in the INI so that when we eventually change timings, we know what to test.

@Miksel12
Copy link
Contributor Author

Probably not a bad idea, especially for obscure titles.

@JMC47
Copy link
Contributor

JMC47 commented Sep 28, 2019

Fake completion should never be used outside of netplay. Other tha nthat, this LGTM. Please use SyncGPU or Single Core instead. If neither works, then we just leave it broken. Fake-completion is egregious.

@JosJuice
Copy link
Member

I don't see a problem with setting fake-completion if the game has been tested to work with it, though I don't think I really would mind setting single core instead.

@JMC47
Copy link
Contributor

JMC47 commented Sep 28, 2019

If Fake-completion is significantly faster and verified to work, I guess we could set it to that for now. Maybe when dualcore is fixed, dualcore will just work.

@Miksel12
Copy link
Contributor Author

Miksel12 commented Sep 29, 2019

I changed all the Fake-completion to single core as it is probably the more compatible choice with these games which have shown to be dual core sensitive.

@leoetlino leoetlino merged commit a5a2771 into dolphin-emu:master Nov 16, 2019
@Miksel12 Miksel12 deleted the ini-dualcore branch November 16, 2019 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants