VideoCommon/OnScreenDisplay: Minor cleanup #8269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides a deterministic initial state in the case of the default constructor.
…value Allows callers to std::move strings into the functions (or automatically assume the move constructor/move assignment operator for rvalue references, potentially avoiding copies altogether.
While we're at it, fix up the imgui include to use the convention we use for referencing external library headers.
Same behavior without hardcoding the type of the mutex within the lock guards. This means the type of the mutex would be able to be changed without needing to also change all occurrences lock guards are used.
AddMessage() by itself doesn't perform string formatting facilities, so this message was actually using the EFB scale as a duration value, not a format argument. This corrects that.
BhaaLseN
approved these changes
Jul 29, 2019
CookiePLMonster
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performs some tidying up of the on screen display interface. Notably, it allows moving into the function, which would be the case for most usages of the functions, allowing copies to be avoided entirely in these scenarios.
This also fixes a format string within the hotkey scheduler. This string should have been within a
StringFromFormatcall rather than being passed directly to AddMessage().