Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GDB stub build #8262

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Fix GDB stub build #8262

merged 1 commit into from
Jul 25, 2019

Conversation

Tilka
Copy link
Member

@Tilka Tilka commented Jul 23, 2019

This only fixes the build. The GDB stub itself doesn't quite work at the moment.

Copy link
Contributor

@stenzek stenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stenzek stenzek merged commit a8bbbd0 into dolphin-emu:master Jul 25, 2019
@Tilka Tilka deleted the gdbstub branch July 26, 2019 00:12
leoetlino added a commit to leoetlino/dolphin that referenced this pull request Dec 25, 2020
While the gdbstub is somewhat broken at the moment, building it by
default should keep us from breaking the build (which has happened
several times in the past: dolphin-emu#2614, dolphin-emu#5904, dolphin-emu#8262).

It isn't very intrusive and it does nothing unless it is enabled
in the config file.
Filoppi pushed a commit to Filoppi/dolphin that referenced this pull request Jan 6, 2021
While the gdbstub is somewhat broken at the moment, building it by
default should keep us from breaking the build (which has happened
several times in the past: dolphin-emu#2614, dolphin-emu#5904, dolphin-emu#8262).

It isn't very intrusive and it does nothing unless it is enabled
in the config file.
Minty-Meeo pushed a commit to Minty-Meeo/dolphin that referenced this pull request Mar 17, 2021
While the gdbstub is somewhat broken at the moment, building it by
default should keep us from breaking the build (which has happened
several times in the past: dolphin-emu#2614, dolphin-emu#5904, dolphin-emu#8262).

It isn't very intrusive and it does nothing unless it is enabled
in the config file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants