Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetPlay: Remove 'reduce polling rate' option #8230

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

Techjar
Copy link
Contributor

@Techjar Techjar commented Jul 6, 2019

With the SI poll line count fixed, pretty much all games are polling twice per frame anyways, making this option superfluous. Since it's a bit of a gross hack and makes DTMs incompatible with console, let's just bin it.

This is necessarily based on #8236, so don't merge this before that one.

@Techjar Techjar changed the title Remove reduced polling NetPlay: Remove 'reduce polling rate' option Jul 6, 2019
@Techjar Techjar force-pushed the remove-reduced-polling branch from 8df8993 to b728d2f Compare July 9, 2019 03:40
@Helios747
Copy link
Contributor

rebase pls

@Techjar
Copy link
Contributor Author

Techjar commented Aug 26, 2019

Whoops, I forgot about this PR for a bit, sorry.

With the SI poll line count fixed, pretty much all games are polling
twice per frame anyways, making this option superfluous. Since it's a
bit of a gross hack and makes DTMs incompatible with console, let's
just bin it.
@Techjar Techjar force-pushed the remove-reduced-polling branch from b728d2f to a3d8a8b Compare August 26, 2019 06:12
Copy link
Contributor

@stenzek stenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also LGTM

@stenzek stenzek merged commit 230ff47 into dolphin-emu:master Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants