Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set texture cache accuracy to safe for Mii Channel #8179

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Set texture cache accuracy to safe for Mii Channel #8179

merged 1 commit into from
Jun 20, 2019

Conversation

Pokechu22
Copy link
Contributor

The previous accuracy was medium. As per the wiki page:

Corrupted Mii Faces

The Mii Faces will miss some of their properties if Texture Cache Accuracy is not set to Safe. To fix, set it to Safe. Setting it to Medium also works, but the channel has to be reset once after it has started.

I'm not entirely sure what the process for picking defaults is, but it seems like the default should be safe, as medium still causes issues (which, sure, can be worked around by resetting, but that seems silly to be the default).

@Techjar
Copy link
Contributor

Techjar commented Jun 15, 2019 •
edited
Loading

The real mystery is why it was forced to Medium in the first place if it didn't work entirely properly.

@Pokechu22
Copy link
Contributor Author

Huh. I did some digging on the article's history, and it needing to be set to safe was only added on May 2019. There were also some older bugs that were removed for having been fixed in 3.x: 2112 and 5163. However the workarounds for those were different.

Here's the most relevant history for the file. It's a bit awkward to navigate.

The earliest version of the file I could find just by using git blame:

dolphin/Data/User/GameConfig/HACA01.ini

Lines 1 to 9 in 0ecebf5

# HACA01 - Mii Channel
[Core] Values set here will override the main dolphin settings.
[EmuState] The Emulation State. 1 is worst, 5 is best, 0 is not set.
EmulationStateId = 5
EmulationIssues =
[OnFrame] Add memory patches to be applied every frame here.
[ActionReplay] Add action replay cheats here.
[Video]
ProjectionHack = 0

After "Revert gameini database to an older state before texcache rewrite was integrated" (note that this revert doesn't seem to actually be reverting an earlier change to this file, unless it's some change that happened elsewhere):

dolphin/Data/User/GameConfig/HACA01.ini

Lines 1 to 11 in f2848b6

# HACA01 - Mii Channel
[Core] Values set here will override the main dolphin settings.
[EmuState] The Emulation State. 1 is worst, 5 is best, 0 is not set.
EmulationStateId = 5
EmulationIssues =
[OnFrame] Add memory patches to be applied every frame here.
[ActionReplay] Add action replay cheats here.
[Video]
ProjectionHack = 0
[Video_Settings]
SafeTextureCache = True

After a commit titled "Gameini database update. About 142 files updated or added to the database":

dolphin/Data/User/GameConfig/HACA01.ini

Lines 1 to 12 in 0861f52

# HACA01 - Mii Channel
[Core] Values set here will override the main dolphin settings.
[EmuState] The Emulation State. 1 is worst, 5 is best, 0 is not set.
EmulationStateId = 5
EmulationIssues =
[OnFrame] Add memory patches to be applied every frame here.
[ActionReplay] Add action replay cheats here.
[Video]
ProjectionHack = 0
[Video_Settings]
SafeTextureCache = True
SafeTextureCacheColorSamples = 512

After a commit titled "Gameini database cleanup. Remove the lines below since they are no longer necessary: SafeTextureCache = True SafeTextureCacheColorSamples = 128

dolphin/Data/User/GameConfig/HACA01.ini

Lines 1 to 11 in c82d883

# HACA01 - Mii Channel
[Core] Values set here will override the main dolphin settings.
[EmuState] The Emulation State. 1 is worst, 5 is best, 0 is not set.
EmulationStateId = 5
EmulationIssues =
[OnFrame] Add memory patches to be applied every frame here.
[ActionReplay] Add action replay cheats here.
[Video]
ProjectionHack = 0
[Video_Settings]
SafeTextureCacheColorSamples = 512

... all of this doesn't really help much, especially since SafeTextureCache doesn't seem to be an option by itself anymore. git blame and git log --follow don't show anything else. However, I was lucky enough to find fa073da while searching, which makes this change and is pretty explicitly titled "The Mii channel needs SafeTextureCache."

To be entirely honest, I'm still not sure how it got to this point, but at least I can show when those changes happened...

@leoetlino leoetlino merged commit b11f630 into dolphin-emu:master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pokechu22 @Techjar @leoetlino