Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Game INI updates and additions #8164

Closed
wants to merge 1 commit into from
Closed

Game INI updates and additions #8164

wants to merge 1 commit into from

Conversation

Miksel12
Copy link
Contributor

@Miksel12 Miksel12 commented Jun 8, 2019 •
edited
Loading

An update to the Game INI's:
-Adds a few games.
-Disables Dual Core for a bunch of games that crashed with Dual Core enabled in a way that makes it unplayable/unfinishable or caused severe issues.
-Enables MMU for Crunchyroll Channel so it can boot and for Interactive Multi Game Demo Disc with demo's which require MMU.
-Disables defered EFB for games that crashed or showed weird behaviour with defered EFB enabled.
-Sets TextureCacheAccuracy to safe for a few games that need it.
-Sets EFB to texture and ram for a few games that need it.
-Removes Skip EFB access for some games that don't need it anymore.
-Removes Wiimote.Shake and Wiimote.Swing as those are no longer functional.

I also removed TextureCacheAccuracy = Safe from NSMBW because accuracy on fast shows no issues.

@JosJuice
Copy link
Member

JosJuice commented Jun 8, 2019 •
edited
Loading

Since what version of Dolphin is SuggestedAspectRatio non-functional? If it's broken, we should fix it.

@mbc07
Copy link
Member

mbc07 commented Jun 8, 2019

As far as I tested, SuggestedAspectRatio still works as intended, it should be left alone. Also, seems strange that you've set DeferEFBCopies to false for de Blob but hasn't for de Blob 2. Those games share the same engine and whatever is broken on the first de Blob with deferred EFB Copies is very likely to also be broken on de Blob 2...

@Miksel12
Copy link
Contributor Author

Miksel12 commented Jun 8, 2019

I thought I had read somewhere that SuggestedAspectRatio was removed and I couldn't find it in the GameINI. I will add it back.

@mbc07 my main source for these changes is the wiki, the latest test reports of de blob 2 are from before Defer EFB was added. I don't think it is desirable to make changes to the GameINI's without testing.

@Miksel12 Miksel12 force-pushed the ini-changes branch 3 times, most recently from 621acd0 to f1f8836 Compare June 8, 2019 18:15
@iwubcode
Copy link
Contributor

iwubcode commented Jun 8, 2019

Boom Blox also had variable strength swing/shake (RBK.ini) so that can be removed too.

Techjar
Techjar suggested changes Jun 8, 2019
View reviewed changes
Data/Sys/GameSettings/MCD.ini Outdated Show resolved Hide resolved
Data/Sys/GameSettings/HC4.ini Outdated Show resolved Hide resolved
@Miksel12 Miksel12 force-pushed the ini-changes branch 3 times, most recently from 247b1da to 821f1a2 Compare June 8, 2019 21:30
Techjar
Techjar suggested changes Jun 8, 2019
View reviewed changes
Data/Sys/GameSettings/SOM.ini Outdated Show resolved Hide resolved
@Miksel12 Miksel12 force-pushed the ini-changes branch 10 times, most recently from 5ffe09d to 61f91b9 Compare June 14, 2019 11:55
@Miksel12 Miksel12 force-pushed the ini-changes branch 3 times, most recently from 2d12545 to 901a706 Compare June 16, 2019 16:58
@Miksel12
Copy link
Contributor Author

Miksel12 commented Jun 16, 2019 •
edited
Loading

I made some new game INI's for Sega Genisis games but I found out texturecache accuracy was already set at safe in the system wide INI so I removed them.
Most of the game INI's for other Sega Genisis games have Immediate XFB disabled, can this be made a system wide thing? That way I could delete all game specific INI's for Sega Genisis.

@Miksel12
Copy link
Contributor Author

Sonic the Hedgehog on Sega Genisis works with immediately present xfb but it seems that a lot of Sega Genisis games need it disabled.
Is that a valid reason to disabled immediately present xfb in the INI for all Sega Genisis? Games that can work with immediately present xfb still work with it disabled and Sega Genisis games that need it disabled (which seems to be quite a lot) but don't have a INI (which is quite a lot) will work out of the box.

@Miksel12 Miksel12 force-pushed the ini-changes branch 2 times, most recently from d90b540 to 4b02e15 Compare June 20, 2019 22:37
@Miksel12 Miksel12 force-pushed the ini-changes branch 3 times, most recently from 681f43b to 48bd839 Compare June 26, 2019 19:58
@Miksel12
Copy link
Contributor Author

Miksel12 commented Jul 1, 2019 •
edited
Loading

Ok, I think I have most of the game which needed INI changes in order to be 'playable'.
I would still like to set ImmediateXFB system wide for Sega Genesis but would like to know what others think.

@Miksel12 Miksel12 force-pushed the ini-changes branch 2 times, most recently from c8bfa53 to bf834c5 Compare July 21, 2019 23:34
@Miksel12 Miksel12 force-pushed the ini-changes branch 3 times, most recently from fcd675f to 567bea9 Compare August 6, 2019 16:58
@Miksel12 Miksel12 mentioned this pull request Aug 6, 2019
Merged
@Miksel12 Miksel12 mentioned this pull request Aug 23, 2019
Merged
@leoetlino
Copy link
Member

Is any of this still applicable?

@Miksel12
Copy link
Contributor Author

Yes, I'll resolve the conflicts and check that everything is still in order.

@leoetlino leoetlino marked this pull request as draft May 3, 2020 16:37
@Miksel12 Miksel12 closed this Jun 1, 2020
@Miksel12 Miksel12 mentioned this pull request Jun 1, 2020
Merged
@Miksel12 Miksel12 deleted the ini-changes branch June 1, 2020 15:28
@Miksel12 Miksel12 restored the ini-changes branch March 2, 2021 02:25
@Miksel12 Miksel12 deleted the ini-changes branch March 3, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techjar Techjar Techjar requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Miksel12 @JosJuice @mbc07 @iwubcode @leoetlino @Techjar