Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jit64: Make DoubleToSingle a common asm routine #8120

Merged
merged 4 commits into from
Jan 25, 2020
Merged

Jit64: Make DoubleToSingle a common asm routine #8120

merged 4 commits into from
Jan 25, 2020

Conversation

merryhime
Copy link
Contributor

Apologies, @booto, there were bugs in the assembly I hastily wrote in #8111.

Decided to write a unit-test to test the generated code to ensure correctness.

Also decided to add ee0b678 to use the (obvious?) BMI2 instruction.

@booto booto mentioned this pull request May 29, 2019
Closed
@degasus
Copy link
Member

degasus commented May 29, 2019

Fun fact, does this unit test show the broken behavior of our old fast implementation in 2795376 ?

@Tilka Tilka merged commit 709862b into dolphin-emu:master Jan 25, 2020
@merryhime merryhime deleted the cdts branch January 25, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@merryhime @degasus @Tilka @booto @MerryMage