Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a codetype in the Gecko codehandler #8099

Merged
merged 1 commit into from
Nov 9, 2019
Merged

Conversation

Ikalpo
Copy link
Contributor

@Ikalpo Ikalpo commented May 14, 2019

Using the codetype "Load into Gecko Register" (82) would not use the address given, but the base address instead.

Example cheat codes:

82210000 XXXXXXXX
84210000 XXXXXXXX

82200000 XXXXXXXX
84200000 XXXXXXXX

These codes should do nothing, but can crash games with the broken codehandler.

@dreamsyntax
Copy link
Member

This explains an issue I've been having.
👍

@nbohr1more
Copy link

@dolphin-emu-bot rebuild

1 similar comment
@nbohr1more
Copy link

@dolphin-emu-bot rebuild

@BhaaLseN
Copy link
Member

I hope you do realize that you cannot use that command. Besides, you can download that build and copy codehandler.bin over to a more recent one if you want to keep testing it.

Copy link
Member

@dreamsyntax dreamsyntax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No conflicts with latest;
Are there any reasons (other than lack of time from approvers) why this should not be merged?

@leoetlino
Copy link
Member

Well, I think one reason is that no maintainer here (including myself) is very familiar with the codehandler. I'll trust you though...

@leoetlino leoetlino merged commit 07e2e1c into dolphin-emu:master Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants