Bring back MemoryWatcher, but without CoreTiming #8073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
reviewed
May 3, 2019
Techjar
reviewed
May 3, 2019
This reverts commit 0c02e77.
leoetlino
reviewed
May 8, 2019
|
Can you squash the "apply suggestions" commit into the relevant commits please? |
|
Well, since the issues that caused MemoryWatcher to be removed in the first place are now fixed and the feature is actually used, I don't see a reason against adding it back. |
Tilka
reviewed
Jun 2, 2019
| void OnFrameEnd() | ||
| { | ||
| #ifdef USE_MEMORYWATCHER | ||
| s_memory_watcher->Step(); |
There was a problem hiding this comment.
This crashes when playing a fifolog because s_memory_watcher hasn't been initialized.
There was a problem hiding this comment.
Perhaps the memory watcher initialization should be moved from CpuThread to EmuThread?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #8050, and re-applies #4967, changing the MemoryWatcher to step during EndField rather than be tied to CoreTiming.