Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading screens on Metroid Prime Trilogy #8072

Merged
merged 1 commit into from
May 8, 2019
Merged

Fix loading screens on Metroid Prime Trilogy #8072

merged 1 commit into from
May 8, 2019

Conversation

Craftyawesome
Copy link
Contributor

XFB to texture causes magenta loading screens. Defer efb causes the game to flicker between metroid prime loading and the place you are loading in to and other loading screen errors.
Unsure about standalone Prime games

@Craftyawesome
Fix loading screens on Metroid Prime Trilogy
e28c412 
XFB to texture causes magenta loading screens. Defer efb causes the game to flicker between metroid prime loading and the place you are loading in to and other loading screen errors.
@JMC47
Copy link
Contributor

JMC47 commented May 3, 2019 •
edited
Loading

Enabling XFB2RAM is a huge performance drain - are we sure it's worth enabling to fix the loading screens? Maybe the fact the game already uses EFB2RAM means that it's not really going to hurt.

DeferEFB part sounds fine.

@JMC47
Copy link
Contributor

JMC47 commented May 4, 2019

Performance doesn't seem very impacted by XFB2RAM thanks to EFB2RAM being enabled for the scanner. Seems fine to me.

@leoetlino leoetlino merged commit 5ca9933 into dolphin-emu:master May 8, 2019
@Craftyawesome Craftyawesome deleted the r3m-ini branch May 8, 2019 19:02
@dvessel
Copy link
Contributor

dvessel commented Oct 14, 2022 •
edited
Loading

EDIT: never mind this. It looks like it affects MacOS very differently.

I think this should be reverted. DeferEFBCopies changes fixes the initial loading screen but it’s never seen again. The corruption happens for half a second but the performance penalty is nontrivial. It can range from 20-40% throughout the game.

I have not noticed the purple screen with XFBToTextureEnable = True. I’m not far along in any of the games but I think I would have spotted by now. I think this is safe to remove as well.

Q8UqA9X.mp4

dvessel added a commit to dvessel/dolphin that referenced this pull request Oct 14, 2022
@dvessel
Revert dolphin-emu#8072
c573c0d 
Disabling DeferEFBCopies has a big performance cost. Corrupt loading screen it causes is only visible for half a second on initial load. Nothing is affected in game.

Enabling XFBToTextureEnable no longer causes a magenta loading screen.

ImmediateXFBEnable is outdated. No ill effects on or off.
@dvessel dvessel mentioned this pull request Oct 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Craftyawesome @JMC47 @dvessel @leoetlino